From edf26aa45d7b660f6c922b740aa571238764dfb8 Mon Sep 17 00:00:00 2001 From: Davide Cappellini Date: Fri, 21 Aug 2026 22:17:55 +0200 Subject: [PATCH] fix(SAC_LSTM_Bot): enforce MaxHidden cap on SACLSTM_HIDDEN_SIZE (review of #48/#49) --- SAC_LSTM_Bot/src/SAC_LSTM_Bot.nim | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/SAC_LSTM_Bot/src/SAC_LSTM_Bot.nim b/SAC_LSTM_Bot/src/SAC_LSTM_Bot.nim index 2cb5dc7..ac5fe22 100644 --- a/SAC_LSTM_Bot/src/SAC_LSTM_Bot.nim +++ b/SAC_LSTM_Bot/src/SAC_LSTM_Bot.nim @@ -207,6 +207,11 @@ method run(bot: SacBot) = # Weight sync (Q7/Q11): always-latest; rebuild this thread's tensors on change. if pullWeights(myVersion, myHidden, flat): + if myHidden > MaxHidden: + # hArr/cArr are fixed-capacity; a bigger SACLSTM_HIDDEN_SIZE would + # heap-overflow them in tensorToHidden. Loud misconfig beats corruption. + raise newException(ValueError, "SACLSTM_HIDDEN_SIZE=" & $myHidden & + " exceeds MaxHidden=" & $MaxHidden & " (bot-side LSTM persistence cap)") var cur = 0 actor = actorFromFlat(flat, cur, myHidden) actorReady = true