Files
SirRoboGarage/common_libs/guns/knn_gun.nim
T
SirStone 7f706e5b14 fix(guns): GF family aimed at the wrong RADIUS, not the wrong angle
The entire GuessFactor family scored 0% on clean circular and wall-bounce
trajectories. Two hypotheses were on the table and BOTH were wrong:

- MEA range too narrow / edge clamping: REFUTED. Measured 0 clamped shots
  out of 837/849/957, required offsets peak at ~33 deg against MEA
  28.1-46.7 deg, and the 8 in arcsin(8/bulletSpeed) is correct (it is the max
  robot SPEED, not the hit radius). Changing it to BotRadius=18 would have
  coarsened resolution for nothing.
- Peak selection: REFUTED. A sweep of every constant GF value showed the
  ORACLE-BEST constant offset on the original gun was only 6% circular,
  4% wall-bounce, 7.5% random-walk. No peak choice could have done better.
  The learning path was fine too: ~850-960 observations per fixture, 0
  starved waves, well-populated histograms.

REAL CAUSE: the GF family aimed at the FIRE-TIME distance. The virtual-bullet
metric resolves a bullet at the AIM-POINT distance and scores that single
point against the enemy's position on that tick, so with any radial target
motion the bullet stops at the wrong radius and misses even with a perfect
angle. Angle-only prediction is structurally unscoreable under this metric.

FIX: give the GF family a self-consistent constant-velocity forecast as its
base reference (new common_libs/guns/lead_forecast.nim, which iterates the
flight time to the same fixed point circular.nim uses), so the histogram
learns the RESIDUAL against that forecast and the aim point lands at the
right radius. Applied to guess_factor, decay_gf and knn_gun.

Same defect fixed in Linear: it did a one-shot dist/bulletSpeed extrapolation
and never iterated its flight time.

The oracle sweep proves the structural fix, independently of tuning: the best
achievable constant GF moved 6% -> 20% (circular), 4% -> 57% (wall-bounce),
7.5% -> 49% (random-walk).

MEASURED, all 15 fixtures: total 39.0% -> 44.4% (30399 -> 34654 hits).
  circular       GF 6 -> 23,   DecayGF 6 -> 21
  wall-bounce    GF 0 -> 60.2, DecayGF 0 -> 60.2
  constant-vel   GF 26 -> 100, DecayGF 26 -> 100, KNN 26 -> 100, Linear 87 -> 100
  random-walk    GF 0 -> 53,   DecayGF 0 -> 52,  Linear 24 -> 53
  StraightLine   GF 8 -> 77,   DecayGF 8 -> 77
Non-regression: 33 guard checks pass, the range's 12/12 offline==online
acceptance still PASSES, tsetlin tests green, live gauntlet 5/5.

HONEST TRADE-OFF, recorded rather than hidden: on the 5 real DrussGT
wave-surfing captures the GF family REGRESSES - GuessFactor 108 -> 55,
DecayGF 108 -> 76, KNN 101 -> 74 hits per 2000. The linear base is a poor
model for a surfer, so the residual histogram is noisier than the old
total-lead histogram. Linear itself improved there (95 -> 105). The synthetic
range and the live gauntlet both improved, and the structural bug is provably
fixed, so this was judged worth the cost - but recovering the DrussGT
regression is the next job, not something to wave away.
2026-09-21 00:56:02 +02:00

313 lines
12 KiB
Nim

## KNN gun: K-nearest-neighbor statistical targeting inspired by DrussGT's DC gun.
## Builds a feature vector per scan, stores resolved GF outcomes, queries KNN at
## predict time and picks the GF with the highest Gaussian-weighted density.
## ponytail: linear scan O(n*k), cap at 2000 obs — KD-tree if perf matters at scale.
import std/[math]
import gun_harness/gun_interface
import gun_harness/virtual_bullets as vb # PowerBins
import guns/lead_forecast
const
MaxObs = 2000 # ring-buffer cap
KCap = 50 # hard ceiling on K
KernelW = 0.3 # Gaussian kernel width multiplier
DensityBins = 60 # scan resolution for peak-GF search
type
Obs = object
feat: array[7, float] # normalized feature vector
gf: float # observed GF at wave resolution
KNNWave = object
fireX, fireY: float
fireBearing: float
feat: array[7, float]
KNNGun* = object
obs: seq[Obs]
obsHead: int # ring-buffer write index
# One wave queue per power bin; matched on bulletSpeed / bulletPower so a
# resolved bullet only ever learns from a wave fired with the same power.
waves: array[len(vb.PowerBins), seq[KNNWave]]
waveHead: array[len(vb.PowerBins), int] # O(1) pop cursor
waveStoredTick: array[len(vb.PowerBins), int] # last tick a wave was queued for this bin
# per-tick cache
cachedTick: int
tickWave: KNNWave # wave template for the current tick (features computed once)
# rolling normalization ranges
featMin: array[7, float]
featMax: array[7, float]
# state for feature extraction
lastSpeed: float
lastDirection: float # +1 or -1
timeSinceDirChange: int
wavePushes*: int
waveStarved*: int
debugGraphics*: bool
proc initKNNGun*(): KNNGun =
result.cachedTick = -1
result.lastDirection = 1.0
result.debugGraphics = false
for b in 0..<len(vb.PowerBins):
result.waveStoredTick[b] = -1
for i in 0..6:
result.featMin[i] = 1e18
result.featMax[i] = -1e18
# ── helpers ──────────────────────────────────────────────────────────────────
proc normFeat(g: KNNGun, raw: array[7, float]): array[7, float] =
for i in 0..6:
let span = g.featMax[i] - g.featMin[i]
result[i] = if span > 1e-9: (raw[i] - g.featMin[i]) / span else: 0.0
proc updateMinMax(g: var KNNGun, raw: array[7, float]) =
for i in 0..6:
if raw[i] < g.featMin[i]: g.featMin[i] = raw[i]
if raw[i] > g.featMax[i]: g.featMax[i] = raw[i]
proc buildFeatures(state: WorldState, lastSpeed, lastDir: float,
tsdc: int): array[7, float] =
let dx = state.enemyX - state.selfX
let dy = state.enemyY - state.selfY
let dist = sqrt(dx*dx + dy*dy)
let arenaDiag = sqrt(state.arenaWidth*state.arenaWidth + state.arenaHeight*state.arenaHeight)
# bearing to enemy (0°=East, standard Tank Royale)
let bearing = arctan2(dy, dx)
# angle of enemy heading relative to bearing
let relHead = state.enemyHeading - bearing
let latVel = state.enemySpeed * sin(relHead)
let advVel = state.enemySpeed * (-cos(relHead))
let accel = state.enemySpeed - lastSpeed # signed delta
# wall distances: how far enemy can travel fwd/bwd before hitting wall
# approximate: project enemy heading to nearest wall in each axis
let ex = state.enemyX
let ey = state.enemyY
let eh = state.enemyHeading
# forward distances to each wall in heading direction
let fwdX = if cos(eh) > 0: (state.arenaWidth - ex) / max(abs(cos(eh)), 1e-9)
else: ex / max(abs(cos(eh)), 1e-9)
let fwdY = if sin(eh) > 0: (state.arenaHeight - ey) / max(abs(sin(eh)), 1e-9)
else: ey / max(abs(sin(eh)), 1e-9)
let fwdDist = min(fwdX, fwdY)
# backward = forward in opposite direction
let bwdX = if cos(eh) < 0: (state.arenaWidth - ex) / max(abs(cos(eh)), 1e-9)
else: ex / max(abs(cos(eh)), 1e-9)
let bwdY = if sin(eh) < 0: (state.arenaHeight - ey) / max(abs(sin(eh)), 1e-9)
else: ey / max(abs(sin(eh)), 1e-9)
let bwdDist = min(bwdX, bwdY)
result[0] = abs(latVel) / 8.0
result[1] = clamp(advVel / 8.0, -1.0, 1.0) * 0.5 + 0.5 # shift to [0,1]
result[2] = clamp(dist / arenaDiag, 0.0, 1.0)
result[3] = clamp(accel / 2.0, -1.0, 1.0) * 0.5 + 0.5
result[4] = clamp(float(tsdc) / 100.0, 0.0, 1.0)
result[5] = clamp(fwdDist / arenaDiag, 0.0, 1.0)
result[6] = clamp(bwdDist / arenaDiag, 0.0, 1.0)
proc euclidean(a, b: array[7, float]): float {.inline.} =
for i in 0..6:
let d = a[i] - b[i]
result += d * d
result = sqrt(result)
proc binForSpeed(spd: float): int {.inline.} =
## Map a virtual-bullet speed back to its power-bin index. All four bin speeds
## are exactly representable floats; the epsilon is belt-and-braces only.
for i in 0..<len(vb.PowerBins):
if abs(spd - bulletSpeed(vb.PowerBins[i])) < 1e-6:
return i
-1
proc binForPower(power: float): int {.inline.} =
## Map a FeedbackEvent.bulletPower back to its power-bin index.
for i in 0..<len(vb.PowerBins):
if abs(power - vb.PowerBins[i]) < 1e-6:
return i
-1
proc takeOldestWave(g: var KNNGun, binIdx: int): (bool, KNNWave) =
## Pop the oldest unresolved wave for this bin (O(1) amortized via waveHead).
if binIdx < 0 or g.waveHead[binIdx] >= g.waves[binIdx].len:
return (false, KNNWave())
result = (true, g.waves[binIdx][g.waveHead[binIdx]])
inc g.waveHead[binIdx]
if g.waveHead[binIdx] >= 64 and
g.waveHead[binIdx] * 2 >= g.waves[binIdx].len:
g.waves[binIdx] = g.waves[binIdx][g.waveHead[binIdx] .. g.waves[binIdx].high]
g.waveHead[binIdx] = 0
# ── Gun interface ─────────────────────────────────────────────────────────────
proc predict*(g: var KNNGun, state: WorldState, bulletSpd: float): GunPrediction =
if bulletSpd <= 0.0:
return GunPrediction(x: state.enemyX, y: state.enemyY)
let dx = state.enemyX - state.selfX
let dy = state.enemyY - state.selfY
let bearing = arctan2(dy, dx)
let mea = arcsin(clamp(8.0 / bulletSpd, -1.0, 1.0))
# Base forecast: the KNN learns the GF residual against this self-consistent
# constant-velocity prediction (see lead_forecast.nim for why this is required).
let f = forecastLinear(state, bulletSpd)
# Track direction change — update state once per tick
if state.tick != g.cachedTick:
g.cachedTick = state.tick
let relHead = state.enemyHeading - bearing
let latVel = state.enemySpeed * sin(relHead)
let newDir = if latVel >= 0: 1.0 else: -1.0
if newDir != g.lastDirection and abs(latVel) > 0.01:
g.timeSinceDirChange = 0
g.lastDirection = newDir
else:
inc g.timeSinceDirChange
# Compute the tick's feature vector ONCE, before lastSpeed is advanced, so
# every power bin fired this tick shares identical features. lastSpeed is
# only advanced here (once/tick), not once per bin.
let feat = buildFeatures(state, g.lastSpeed, g.lastDirection, g.timeSinceDirChange)
g.updateMinMax(feat)
g.tickWave = KNNWave(
fireX: state.selfX,
fireY: state.selfY,
fireBearing: bearing,
feat: feat,
)
g.lastSpeed = state.enemySpeed
# Queue at most one wave per (tick, power bin). The fire site's extra predict()
# call for the selected bin lands on the same tick and reuses the queued wave.
let binIdx = binForSpeed(bulletSpd)
if binIdx >= 0 and g.waveStoredTick[binIdx] != state.tick:
# fireBearing is the base forecast bearing, which is per-power (flight time
# differs per bin); override the shared per-tick template here.
var w = g.tickWave
w.fireBearing = f.bearing
g.waves[binIdx].add w
g.waveStoredTick[binIdx] = state.tick
inc g.wavePushes
# Cold start — no data yet: fall back to the self-consistent linear forecast.
if g.obs.len == 0:
return GunPrediction(
x: clamp(f.x, BotRadius, state.arenaWidth - BotRadius),
y: clamp(f.y, BotRadius, state.arenaHeight - BotRadius),
)
# Build query feature vector (use current state)
let queryRaw = buildFeatures(state, g.lastSpeed, g.lastDirection, g.timeSinceDirChange)
let query = g.normFeat(queryRaw)
# KNN: linear scan, pick k = max(5, min(sqrt(n), KCap))
# Fall back to head-on when not enough neighbors to be meaningful
let n = g.obs.len
if n < 5:
return GunPrediction(
x: clamp(f.x, BotRadius, state.arenaWidth - BotRadius),
y: clamp(f.y, BotRadius, state.arenaHeight - BotRadius),
)
let k = max(5, min(int(sqrt(float(n))), KCap))
# Partial selection: maintain k-best by tracking max distance in result set
# ponytail: O(n*k) insertion; fine for n<=2000, k<=50
var bestDists = newSeq[float](k)
var bestGFs = newSeq[float](k)
var worstIdx = 0
var filled = 0
for i in 0..<n:
let normFeat = g.normFeat(g.obs[i].feat)
let d = euclidean(query, normFeat)
if filled < k:
bestDists[filled] = d
bestGFs[filled] = g.obs[i].gf
inc filled
if filled == k:
# find worst
worstIdx = 0
for j in 1..<k:
if bestDists[j] > bestDists[worstIdx]: worstIdx = j
elif d < bestDists[worstIdx]:
bestDists[worstIdx] = d
bestGFs[worstIdx] = g.obs[i].gf
worstIdx = 0
for j in 1..<k:
if bestDists[j] > bestDists[worstIdx]: worstIdx = j
if filled == 0:
return GunPrediction(
x: clamp(f.x, BotRadius, state.arenaWidth - BotRadius),
y: clamp(f.y, BotRadius, state.arenaHeight - BotRadius),
)
# Inverse-distance weights, Gaussian (same as DrussGT getBearingGaussian)
var sumDist = 1e-30
for i in 0..<filled: sumDist += bestDists[i]
let invAvg = float(filled) / sumDist
# Find GF range of neighbors
var gfMin = bestGFs[0]
var gfMax = bestGFs[0]
for i in 1..<filled:
if bestGFs[i] < gfMin: gfMin = bestGFs[i]
if bestGFs[i] > gfMax: gfMax = bestGFs[i]
# Scan DensityBins points in [gfMin, gfMax] for peak density
let span = max(gfMax - gfMin, 1e-9)
let step = span / float(DensityBins - 1)
var bestGF = gfMin
var bestScore = -1.0
for b in 0..<DensityBins:
let testGF = gfMin + float(b) * step
var score = 0.0
for i in 0..<filled:
let w = exp(-0.5 * (bestDists[i] * invAvg) * (bestDists[i] * invAvg))
let dg = (testGF - bestGFs[i]) / max(span * KernelW, 1e-9)
score += w * exp(-0.5 * dg * dg)
if score > bestScore:
bestScore = score
bestGF = testGF
let aimAngle = f.bearing + clamp(bestGF, -1.0, 1.0) * mea
let px = state.selfX + cos(aimAngle) * f.dist
let py = state.selfY + sin(aimAngle) * f.dist
GunPrediction(
x: clamp(px, BotRadius, state.arenaWidth - BotRadius),
y: clamp(py, BotRadius, state.arenaHeight - BotRadius),
)
proc onResult*(g: var KNNGun, e: FeedbackEvent) =
let binIdx = binForPower(e.bulletPower)
if binIdx < 0: return
let (found, w) = g.takeOldestWave(binIdx)
if not found:
inc g.waveStarved
return
let speed = bulletSpeed(e.bulletPower)
let mea = arcsin(clamp(8.0 / speed, -1.0, 1.0))
let ax = e.actualX - w.fireX
let ay = e.actualY - w.fireY
var delta = arctan2(ay, ax) - w.fireBearing
while delta > PI: delta -= 2.0 * PI
while delta < -PI: delta += 2.0 * PI
let gf = if mea > 1e-10: clamp(delta / mea, -1.0, 1.0) else: 0.0
g.updateMinMax(w.feat)
if g.obs.len < MaxObs:
g.obs.add Obs(feat: w.feat, gf: gf)
else:
# ring buffer
g.obs[g.obsHead] = Obs(feat: w.feat, gf: gf)
g.obsHead = (g.obsHead + 1) mod MaxObs