2 Commits

Author	SHA1	Message	Date
SirStone	eb74f9b2e3	Ram: finisher-only by default, and the bullet-rain abort now measures real energy ... Follows the diagnosis that proactive straight-line ramming CANNOT work: both bots have MAX_SPEED=8, so a pursuit cannot catch an evading equal-speed opponent. Measured over 49 rounds per arm, opportunity -> contact was **0/6** (base), 0/40 (ring), 0/12 (ringhot). The only proactive conversion in the whole corpus came from a FINISHER, and only because a <20-energy DrussGT stops fleeing (that episode closed at 6-8 px/tick). Opportunity episodes never got below ~80px; one ran the full 60-tick duration cap and closed only 198->171px; a perfectly aligned full-speed one closed 195->114px then plateaued. CHANGES - **Finisher-only default.** `finisher` (<20 energy, dist<300, we are healthier) and the rare `desperation` (both <5, dist<150) are kept; `opportunity` and the speculative `plan` are OFF. Both are env-reenableable with no rebuild: `TR_RAM_OPPORTUNITY=1` (tune via TR_RAM_OPP_DIST/MARGIN) and `TR_RAM_PLAN=1`. Justification: it removes 100+ non-converting episodes per fixture at zero measured loss (oldram vs base was p=0.69, damage 279 vs 284, survival 17/49 vs 16/49) - and each of those episodes spent up to 60 ticks driving STRAIGHT at the enemy, abandoning the mover's dodging and disrupting aim. - **`desperation` KEPT** deliberately: it is cheap and rare, fires only when both bots are nearly dead at short range (a coin-flip where 0.6 contact can decide it), and it is not the refuted straight-line pursuit. - **THE BULLET-RAIN ABORT WAS DEAD CODE AND IS NOW FIXED.** `onHitByBullet` accumulated raw bullet FIREPOWER while `TR_RAM_ABORT_DMG = 0.5` was documented as a DAMAGE rate - so the bar was implicitly "sum of power > 7.5 over 15 turns" and the maximum rate ever observed was 0.27. It now accumulates REAL ENERGY via a `bulletDamage(power)` helper matching the server's `4p` / `6p-2` formula, and `TR_RAM_ABORT_DMG` defaults to **2.0 energy/turn** (~30 HP over 15 turns): "abort an in-progress ram if we take > 2.0 energy per turn". Same effective bar for normal firepower, and it can now actually fire - the live run reports `dmgRate=1.07/turn` where the old units said 0.27. - **`ramStuckTicks` REMOVED.** It required `dist < 5px`; contact occurs at ~36px (two 18px radii) and position rewind prevents getting closer, so it could never increment. Only the 60-tick duration cap can now self-end a ram. LIVENESS (measured, default config, vs a charging Java RamFire, 3 rounds): default -> `[ram] ON reason=finisher` x3, `reason=opportunity` x0 TR_RAM_OPPORTUNITY=1 -> `reason=opportunity` x4, `reason=finisher` x2 So the opportunity states DID occur and are suppressed by the new default - the removal is real, not an arm that never fires. A line also read `[ram] OFF reason=duration dmgRate=1.07/turn`, confirming the new energy units. Adds docs/ramming_negative_result.md (70 lines) recording the question, the five diagnostic answers, the geometric reason, the finisher exception, the two dead code paths, and an explicit "do not re-attempt a proactive straight-line ram; if point-blank forcing is ever wanted it is an INTERCEPTION/cornering movement problem" note - the same pattern that stopped the corpse bug recurring. Guards: test_ram_decision 40 (was 28), test_gun_harness 39, test_vbullet_metric 11, test_power_selection 3, test_adaptive_radar 41, test_tfil_ring_weights 24, test_power_policy 26, test_rack_membership 48, test_selector_tiebreak 19, test_tm_pattern_registration 20, test_vbullet_admit_gate 12, acceptance_offline_vs_online 12/12. ModularBot compiles. Honest note: the abort-threshold fix is a real (tiny) behaviour change, NOT measured-neutral - it only bites while a finisher ram is under sustained fire, which is exactly the user's stated wish. The finisher-only removal itself is measured-neutral per the given A/B.	2026-09-22 08:14:03 +02:00
SirStone	994f88d7a7	ramming: make the decision PROACTIVE, with a bullet-rain abort ... The user watched 1v1 and melee runs and saw ram opportunities arise that the bot declined: "there were moments where the bot could jump over the enemy and shred it but shot it down instead." DIAGNOSIS - a chicken-and-egg loop. `ramOpportunity` required dist < 50px, but an offline measurement over 15 rounds vs DrussGT found the closest approach was 118.7px and the <50px trigger had NEVER fired: the mover has no reason to close, so the trigger waited for a proximity nothing created. The MECHANISM to close already existed (the ring mover expresses a ram as band=(0,50)); what was missing was a decision that fires at a range the bot can actually close from. Changes: - opportunity gate relaxed: dist 50 -> TR_RAM_OPP_DIST (200), energy margin +30 -> TR_RAM_OPP_MARGIN (15). Both env-tunable, no rebuild needed. - New pure module `common_libs/movements/ram_decision.nim` holding the trigger and abort logic (no battle/API deps), so it is unit-testable. - BULLET-RAIN ABORT (the user asked for this earlier): `onHitByBullet` now accumulates `e.bullet.power` into a 15-turn ring; damageRatePerTurn = sum/15; an in-progress ram aborts when rate > TR_RAM_ABORT_DMG (0.5/turn). On abort: isRamming=false, cooldown 30, TARGET KEPT, and the mover returns to the normal range band. It never stops the bot. - Opt-in, DEFAULT-OFF `plan` trigger for "change of plan when the gun duel is failing" (dist<250, margin+20, selected gun's pooled virtual rate < 0.05). Left off because a cold gun reads 0.0 and would qualify - speculative. - `TR_RAM_LOG=1` change-gated line: `[ram] ON reason=opportunity dist=143 selfE=78 enemyE=41 cap=3.0 band=[0,50]` / `[ram] OFF reason=bulletRain`. - Existing cooldown/duration/stuck machinery untouched (stuck>10 or duration>60 -> abort + cooldown 30). A refactor bug that briefly DROPPED the `ramCooldownTicks == 0` gate was caught and fixed. Trigger set (first match wins): finisher (dist<300, enemy<20, we are healthier); opportunity (dist<200, we lead by 15+); desperation (both <5, dist<150); plan (off). All require enemy>0, a valid target, and no cooldown. Proof the intent now fires at a closable distance (28/28 unit checks): PASS: opportunity fires at dist 143 with a 37-energy lead <- the exact case PASS: old gate (dist<50, margin+30) does NOT fire at 143 <- the old bug PASS: fires at 199px / does NOT fire at 201px + margin, finisher priority, desperation, plan on/off, window mean, abort threshold checks. HONEST FRAMING: ram damage is 0.6 per CONTACT EVENT, one-shot (collision resolution rewinds positions so contacts do not stream) - small next to a p=3.0 bullet hit (16). The payoff is that point-blank forces hit probability toward 1, so heavy bullets stop missing and E[dE]=p(3P-1) turns positive above P=1/3; ram damage also scores 2.0/point (highest in the game) and a ram kill carries a 0.30 bonus vs 0.20. So this is "force the fight to point-blank", not "the ram shreds them". Base rate is rare (2 collisions in the whole fixture corpus). Guards: test_ram_decision 28 (new), test_power_policy 26, test_gun_harness 39, test_vbullet_metric 11, test_power_selection 3, test_adaptive_radar 41, test_tfil_ring_weights 24. Compiles (release). UNVERIFIED: the live effect. No A/B has run, and whether the mover actually reaches contact is unproven.	2026-09-22 00:24:45 +02:00