SirStone
589a230106
retracts its own earlier learning claim === TASK 1: REGISTERED AS GUN 14, DEFAULT `off` === The radial TM gun is now a first-class rack member (`TMPATTERN`, id 14), forceable alone with `TR_RACK_TMPATTERN=both` plus every other `TR_RACK_*=off`. DEFAULT IS `off`, and the justification matters: `both` would let it compete for selection AND (because the shared VirtualTracker ring is order-sensitive) shift every other gun's learning order, so it CANNOT leave the default path unchanged. With `off` its predict and spawnBullets are additionally GATED on rack admission (the only gun wired that way), so the shipped default never spawns it at all: zero cost, zero ring perturbation. Live proof: 1-round battle with only TMPATTERN racked -> `gun 14 (TMPattern): vShots=400 selected=104 other-gun selections=0`. Default-path-unchanged proof: parity checks that the 15-gun default bestGun/ selectGun equals the old 14-gun rack RNG-draw-for-RNG-draw, that gun 14 is never selected by default, and acceptance 12/12. Cost: 0.36 ms/tick (predict 0.30 + onResult 0.05) ~= 3% of the 13.16 ms budget. Tsetlin in the same harness is 1.62 ms/tick, so the new gun is ~4.5x cheaper. === TASK 2: THE LABEL-BIAS FIX - AND A RETRACTION === Root cause confirmed: under bmPoint a SHORT radial correction resolves the virtual bullet BEFORE the base arrival tick, so the label was dropped (labelMisses). Fix: defer the label in a pending queue and flush it once the arrival tick is recorded; labels still come from the BASE arrival tick. labelMisses 4,281,695 -> 0 training samples 1,071,824 -> 5,345,847 (x5) radial head acc 48.8% -> 57.0% (shuffled control 20.0%) bmPoint hit rate 9.4/5.8% -> 9.1/5.7% (unchanged, within noise) So the fix IMPROVES LEARNING but NOT the metric. **RETRACTION OF THE PREVIOUS JOB'S CLAIM.** It reported the radial head's 48.8% against a 36.7% majority baseline and concluded "conditional learning, not a constant bias". With the bias removed, the correctly-measured majority baseline is **58.2%** - so the head at 57.0% is AT/BELOW majority. The earlier apparent conditional learning was PARTLY AN ARTEFACT OF THE BIASED SAMPLE. The bmPoint metric win is real (TMRadial > Linear early 16/2 p=0.0013, overall 18/0 p<0.0001; > shuffled 18/0 p<0.0001) but it comes from a NET-POSITIVE AVERAGE RADIAL SHIFT, not from beating a majority classifier. Recorded plainly rather than left standing. Guards: test_tm_pattern_registration 20 (new), test_tm_pattern_rack_live 4 (new), test_gun_harness 39, test_vbullet_metric 11, test_power_selection 3 (the SIGSEGV is gone - the knn_gun rewrite is now committed), test_adaptive_radar 41, test_tfil_ring_weights 24, test_power_policy 26, test_ram_decision 28, test_rack_membership 38, test_selector_tiebreak 19, test_tm_pattern_learning 3, acceptance_offline_vs_online 12/12. ModularBot compiles (release). Note: `common_libs/tests/range_guns.nim` still builds 14 offline drivers (the offline sweep constructs TmPatternGun directly and acceptance only inspects ids 0..13), so nothing breaks - but a future job wanting it in the offline rack must add a 15th driver and mirror the live admission gating. gun_stats.jsonl now emits 15 rows; downstream tooling should ignore id 14.
242 lines
10 KiB
Nim
242 lines
10 KiB
Nim
## Pure unit guard for the melee/1v1 rack-membership mechanism.
|
|
##
|
|
## No Java, no battle, no virtual bullets: the fitness windows are seeded
|
|
## directly so the selection is deterministic and fast. Covers:
|
|
## * mode filtering selects the right gun subset,
|
|
## * an EMPTY filtered set falls back to the full rack,
|
|
## * `TR_RACK_<GUN>` env overrides parse correctly (both / 1v1 / melee / off),
|
|
## * the shipped defaults are all-`both`,
|
|
## * the default configuration reproduces the pre-change selection exactly.
|
|
##
|
|
## Run with plain:
|
|
## nim c -r common_libs/tests/test_rack_membership.nim
|
|
|
|
import std/[random, tables, os, strutils]
|
|
import gun_harness/gun_interface
|
|
import gun_harness/virtual_bullets
|
|
import gun_harness/selector
|
|
|
|
var failures = 0
|
|
proc check(name: string, ok: bool) =
|
|
if ok: echo "PASS: ", name
|
|
else: echo "FAIL: ", name; inc failures
|
|
|
|
proc recordHit(fw: var FitnessWindow, hit: bool) =
|
|
fw.hits[fw.head] = hit
|
|
fw.head = (fw.head + 1) mod WindowSize
|
|
inc fw.count
|
|
|
|
proc seedWindow(t: var VirtualTracker, targetId, gunId, binIdx, hits, misses: int) =
|
|
if targetId notin t.fitness:
|
|
t.fitness[targetId] = newSeq[GunFitness](t.numGuns)
|
|
var fw = addr t.fitness[targetId][gunId].bins[binIdx]
|
|
for _ in 0..<hits: recordHit(fw[], true)
|
|
for _ in 0..<misses: recordHit(fw[], false)
|
|
|
|
# ── mode derivation (server truth) ────────────────────────────────────────────
|
|
|
|
proc testModeFromEnemyCount() =
|
|
check "rackMode: 1 enemy alive -> 1v1",
|
|
rackMode(1) == rm1v1
|
|
check "rackMode: 2+ enemies alive -> melee",
|
|
rackMode(2) == rmMelee and rackMode(5) == rmMelee
|
|
check "rackMode: 0 enemies (should not occur) stays melee, matching the radar",
|
|
rackMode(0) == rmMelee
|
|
|
|
# ── pure filter ────────────────────────────────────────────────────────────────
|
|
|
|
proc testAdmittedGunsFiltering() =
|
|
# 0: both, 1: only1v1, 2: onlyMelee, 3: off
|
|
let mem = [rmBoth, rmOnly1v1, rmOnlyMelee, rmOff]
|
|
check "admittedGuns(1v1) keeps both + only1v1, drops onlyMelee/off",
|
|
admittedGuns(4, rm1v1, mem) == @[0, 1]
|
|
check "admittedGuns(melee) keeps both + onlyMelee, drops only1v1/off",
|
|
admittedGuns(4, rmMelee, mem) == @[0, 2]
|
|
|
|
proc testEmptyFilterFallsBackToFullRack() =
|
|
let allOff = [rmOff, rmOff, rmOff, rmOff]
|
|
check "admittedGuns: all-off rack degrades to the FULL rack (1v1)",
|
|
admittedGuns(4, rm1v1, allOff) == @[0, 1, 2, 3]
|
|
check "admittedGuns: all-off rack degrades to the FULL rack (melee)",
|
|
admittedGuns(4, rmMelee, allOff) == @[0, 1, 2, 3]
|
|
# A rack where only melee guns exist still falls back to all guns in 1v1.
|
|
let onlyMelee = [rmOnlyMelee, rmOnlyMelee]
|
|
check "admittedGuns: a rack with NO gun for the mode degrades to the full rack",
|
|
admittedGuns(2, rm1v1, onlyMelee) == @[0, 1]
|
|
|
|
proc testEmptyMembershipMeansNoFiltering() =
|
|
check "admittedGuns: an empty membership table filters nothing",
|
|
admittedGuns(3, rm1v1, []) == @[0, 1, 2]
|
|
check "rackAdmitted: an empty membership table admits every id",
|
|
rackAdmitted(0, rm1v1, []) and rackAdmitted(99, rmMelee, [])
|
|
|
|
proc testRackAdmitted() =
|
|
let mem = [rmBoth, rmOnly1v1, rmOff]
|
|
check "rackAdmitted: both is admitted in every mode",
|
|
rackAdmitted(0, rm1v1, mem) and rackAdmitted(0, rmMelee, mem)
|
|
check "rackAdmitted: only1v1 is admitted only in 1v1",
|
|
rackAdmitted(1, rm1v1, mem) and not rackAdmitted(1, rmMelee, mem)
|
|
check "rackAdmitted: off is never admitted",
|
|
not rackAdmitted(2, rm1v1, mem) and not rackAdmitted(2, rmMelee, mem)
|
|
check "rackAdmitted: negative id is never admitted",
|
|
not rackAdmitted(-1, rm1v1, mem)
|
|
|
|
# ── selection-level filtering ─────────────────────────────────────────────────
|
|
|
|
proc testSelectionFollowsMode() =
|
|
# gun0 50%, gun1 100% (1v1 only), gun2 100% (melee only).
|
|
var t = initTracker(3)
|
|
seedWindow(t, 7, 0, 0, 25, 25)
|
|
seedWindow(t, 7, 1, 0, 50, 0)
|
|
seedWindow(t, 7, 2, 0, 50, 0)
|
|
let mem = @[rmBoth, rmOnly1v1, rmOnlyMelee]
|
|
randomize(7)
|
|
var one: array[3, int]
|
|
for _ in 0..<100: inc one[t.bestGun(7, rackMode = rm1v1, membership = mem)]
|
|
var melee: array[3, int]
|
|
for _ in 0..<100: inc melee[t.bestGun(7, rackMode = rmMelee, membership = mem)]
|
|
check "selection: 1v1 rack only ever returns admitted guns {0,1}",
|
|
one[2] == 0 and one[0] + one[1] == 100
|
|
check "selection: 1v1 rack picks the only1v1 gun when it dominates",
|
|
one[1] == 100
|
|
check "selection: melee rack only ever returns admitted guns {0,2}",
|
|
melee[1] == 0 and melee[0] + melee[2] == 100
|
|
check "selection: melee rack picks the onlyMelee gun when it dominates",
|
|
melee[2] == 100
|
|
|
|
proc testSelectionEmptyFilterFallsBack() =
|
|
var t = initTracker(3)
|
|
seedWindow(t, 7, 0, 0, 10, 40) # 20%
|
|
seedWindow(t, 7, 1, 0, 50, 0) # 100%
|
|
seedWindow(t, 7, 2, 0, 10, 40) # 20%
|
|
let allOff = @[rmOff, rmOff, rmOff]
|
|
randomize(11)
|
|
var seen: array[3, int]
|
|
for _ in 0..<100: inc seen[t.bestGun(7, rackMode = rm1v1, membership = allOff)]
|
|
check "selection: an all-off rack still selects (falls back to full rack)",
|
|
seen[0] + seen[1] + seen[2] == 100
|
|
check "selection: the fallback still picks the best gun (gun 1)",
|
|
seen[1] == 100
|
|
|
|
# ── env parsing / defaults ────────────────────────────────────────────────────
|
|
|
|
proc clearRackEnv() =
|
|
for name in RackGunNames:
|
|
delEnv("TR_RACK_" & name)
|
|
|
|
proc testParseMembership() =
|
|
check "parse: 'both' -> rmBoth", parseRackMembership("both") == rmBoth
|
|
check "parse: '1v1' -> rmOnly1v1", parseRackMembership("1v1") == rmOnly1v1
|
|
check "parse: 'melee' -> rmOnlyMelee", parseRackMembership("melee") == rmOnlyMelee
|
|
check "parse: 'off' -> rmOff", parseRackMembership("off") == rmOff
|
|
check "parse: case/whitespace-insensitive",
|
|
parseRackMembership(" 1V1 ") == rmOnly1v1 and
|
|
parseRackMembership("MeLeE") == rmOnlyMelee
|
|
check "parse: empty -> shipped default rmBoth",
|
|
parseRackMembership("") == rmBoth
|
|
check "parse: unknown -> rmBoth (never fatal)",
|
|
parseRackMembership("banana") == rmBoth
|
|
|
|
proc testDefaultsAllBoth() =
|
|
clearRackEnv()
|
|
# The shipped table is all-`both` EXCEPT the new TM pattern gun (id 14),
|
|
# which defaults to `off` so it cannot alter the default selection.
|
|
var allBoth = true
|
|
for i in 0..<RackGunNames.len:
|
|
let want = if i == 14: rmOff else: rmBoth
|
|
if DefaultRackMembership[i] != want: allBoth = false
|
|
check "defaults: the shipped table is all-`both` except TMPATTERN=off", allBoth
|
|
let loaded = loadRackMembership()
|
|
check "defaults: with a clean environment loadRackMembership() == shipped table",
|
|
loaded == DefaultRackMembership
|
|
check "defaults: RackGunNames covers the shipped 15-gun rack",
|
|
RackGunNames.len == 15 and DefaultRackMembership.len == 15
|
|
|
|
proc testEnvOverrides() =
|
|
clearRackEnv()
|
|
putEnv("TR_RACK_TSETLIN", "1v1")
|
|
putEnv("TR_RACK_DISPLACE", "melee")
|
|
putEnv("TR_RACK_HEADON", "off")
|
|
let m = loadRackMembership()
|
|
check "env: TR_RACK_TSETLIN=1v1 moves only Tsetlin (id 2)",
|
|
m[2] == rmOnly1v1
|
|
check "env: TR_RACK_DISPLACE=melee moves only Displace (id 9)",
|
|
m[9] == rmOnlyMelee
|
|
check "env: TR_RACK_HEADON=off removes only HeadOn (id 0)",
|
|
m[0] == rmOff
|
|
check "env: every untouched gun keeps its shipped default",
|
|
m[1] == rmBoth and m[3] == rmBoth and m[13] == rmBoth and m[14] == rmOff
|
|
putEnv("TR_RACK_KNN", "banana")
|
|
check "env: unknown values are ignored, not fatal",
|
|
loadRackMembership()[12] == rmBoth
|
|
clearRackEnv()
|
|
|
|
# ── parity: default path reproduces pre-change selection ─────────────────────
|
|
|
|
proc testDefaultReproducesPreChange() =
|
|
## The pre-change selector is `bestGun(t, id)` (empty membership). With the
|
|
## all-`both` default table and EITHER mode, the selection sequence must be
|
|
## identical, RNG draw for RNG draw.
|
|
var t = initTracker(5)
|
|
seedWindow(t, 7, 0, 0, 60, 40)
|
|
seedWindow(t, 7, 1, 0, 40, 60)
|
|
seedWindow(t, 7, 2, 0, 80, 20)
|
|
seedWindow(t, 7, 3, 0, 55, 45)
|
|
seedWindow(t, 7, 4, 0, 20, 80)
|
|
let allBoth = @[rmBoth, rmBoth, rmBoth, rmBoth, rmBoth]
|
|
randomize(1234)
|
|
var pre: seq[int]
|
|
for _ in 0..<300: pre.add t.bestGun(7)
|
|
randomize(1234)
|
|
var as1v1: seq[int]
|
|
for _ in 0..<300: as1v1.add t.bestGun(7, rackMode = rm1v1, membership = allBoth)
|
|
randomize(1234)
|
|
var asMelee: seq[int]
|
|
for _ in 0..<300: asMelee.add t.bestGun(7, rackMode = rmMelee, membership = allBoth)
|
|
check "parity: all-`both` membership reproduces pre-change selection (1v1)",
|
|
pre == as1v1
|
|
check "parity: all-`both` membership reproduces pre-change selection (melee)",
|
|
pre == asMelee
|
|
|
|
proc testDefaultReproducesPreChangeSelectGun() =
|
|
## Same parity check through the live hysteresis path (`selectGun`).
|
|
var t = initTracker(4)
|
|
seedWindow(t, 7, 0, 0, 60, 40)
|
|
seedWindow(t, 7, 1, 0, 70, 30)
|
|
seedWindow(t, 7, 2, 0, 40, 60)
|
|
seedWindow(t, 7, 3, 0, 50, 50)
|
|
let allBoth = @[rmBoth, rmBoth, rmBoth, rmBoth]
|
|
randomize(99)
|
|
var a = initTracker(4)
|
|
a = t
|
|
var pre: seq[int]
|
|
for tick in 0..<300: pre.add a.selectGun(7, tick = tick)
|
|
randomize(99)
|
|
var b = initTracker(4)
|
|
b = t
|
|
var post: seq[int]
|
|
for tick in 0..<300:
|
|
post.add b.selectGun(7, tick = tick, rackMode = rmMelee, membership = allBoth)
|
|
check "parity: selectGun with all-`both` membership is byte-identical",
|
|
pre == post
|
|
|
|
# ── driver ────────────────────────────────────────────────────────────────────
|
|
|
|
testModeFromEnemyCount()
|
|
testAdmittedGunsFiltering()
|
|
testEmptyFilterFallsBackToFullRack()
|
|
testEmptyMembershipMeansNoFiltering()
|
|
testRackAdmitted()
|
|
testSelectionFollowsMode()
|
|
testSelectionEmptyFilterFallsBack()
|
|
testParseMembership()
|
|
testDefaultsAllBoth()
|
|
testEnvOverrides()
|
|
testDefaultReproducesPreChange()
|
|
testDefaultReproducesPreChangeSelectGun()
|
|
|
|
if failures > 0:
|
|
echo "\n", failures, " check(s) FAILED"
|
|
quit(1)
|
|
echo "\nAll rack-membership checks passed."
|